From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
Xin Long <lucien.xin@gmail.com>
Subject: Re: [PATCH net-next v2 2/3] sctp: add asoc and packet to sctp_flush_ctx
Date: Sun, 13 May 2018 18:40:47 -0300 [thread overview]
Message-ID: <20180513214047.GY5105@localhost.localdomain> (raw)
In-Reply-To: <8de39e2ff04a8a96440c8b5f66cbc5cbc6303067.1526142994.git.marcelo.leitner@gmail.com>
On Sat, May 12, 2018 at 07:21:51PM -0300, Marcelo Ricardo Leitner wrote:
> @@ -1043,20 +1038,17 @@ static bool sctp_outq_flush_rtx(struct sctp_flush_ctx *ctx,
> static void sctp_outq_flush_data(struct sctp_flush_ctx *ctx,
> int rtx_timeout)
> {
> - struct sctp_packet *packet = ctx->transport ? &ctx->transport->packet :
> - NULL;
> - struct sctp_association *asoc = ctx->q->asoc;
> struct sctp_chunk *chunk;
> enum sctp_xmit status;
>
> /* Is it OK to send data chunks? */
> - switch (asoc->state) {
> + switch (ctx->asoc->state) {
> case SCTP_STATE_COOKIE_ECHOED:
> /* Only allow bundling when this packet has a COOKIE-ECHO
> * chunk.
> */
> - if (!packet || !packet->has_cookie_echo)
> - return;
> + if (!ctx->packet || !ctx->packet->has_cookie_echo)
> + break;
This return/break change was by mistake. Will post v3 tomorrow.
next prev parent reply other threads:[~2018-05-13 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 22:21 [PATCH net-next v2 0/3] sctp: Introduce sctp_flush_ctx Marcelo Ricardo Leitner
2018-05-12 22:21 ` [PATCH net-next v2 1/3] sctp: add sctp_flush_ctx, a context struct on outq_flush routines Marcelo Ricardo Leitner
2018-05-12 22:21 ` [PATCH net-next v2 2/3] sctp: add asoc and packet to sctp_flush_ctx Marcelo Ricardo Leitner
2018-05-13 21:40 ` Marcelo Ricardo Leitner [this message]
2018-05-12 22:21 ` [PATCH net-next v2 3/3] sctp: checkpatch fixups Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513214047.GY5105@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).