From: David Miller <davem@davemloft.net>
To: acelan.kao@canonical.com
Cc: jcliburn@gmail.com, chris.snook@gmail.com, rakesh@tuxera.com,
netdev@vger.kernel.org, emily.chien@canonical.com,
andrew@lunn.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Revert "alx: remove WoL support"
Date: Mon, 14 May 2018 09:35:04 -0400 (EDT) [thread overview]
Message-ID: <20180514.093504.1396660355199793729.davem@davemloft.net> (raw)
In-Reply-To: <20180514032839.32079-1-acelan.kao@canonical.com>
From: AceLan Kao <acelan.kao@canonical.com>
Date: Mon, 14 May 2018 11:28:39 +0800
> This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2.
>
> The WoL feature is a must to pass Energy Star 6.1 and above,
> the power consumption will be measured during S3 with WoL is enabled.
>
> Reverting "alx: remove WoL support", and will try to fix the unintentional
> wake up issue when WoL is enabled.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651
>
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
First, we must fix the problem that caused WoL to be disabled.
Then, and only then, can you re-enable it.
Thank you.
next prev parent reply other threads:[~2018-05-14 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 3:28 [PATCH v2] Revert "alx: remove WoL support" AceLan Kao
2018-05-14 13:35 ` David Miller [this message]
2018-05-21 3:14 ` AceLan Kao
2018-05-21 3:18 ` David Miller
2018-05-28 5:06 ` AceLan Kao
2018-05-29 14:57 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2018-05-30 2:10 AceLan Kao
2018-05-30 13:58 ` Andrew Lunn
2018-05-31 2:13 ` AceLan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514.093504.1396660355199793729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acelan.kao@canonical.com \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=emily.chien@canonical.com \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).