Re: [PATCH net-next 2/3] net: qualcomm: rmnet: Add support for ethtool private stats

Subash Abhinov Kasiviswanathan
2018-05-15T18:09:12Z

On 2018-05-15 02:41, kbuild test robot wrote:
> Hi Subash,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-qualcomm-rmnet-Updates-2018-05-14/20180515-115355
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:199:26: sparse:
>>> symbol 'rmnet_ethtool_ops' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation

Thanks Fengguang. I will fix both issues in v2

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project