From: David Miller <davem@davemloft.net>
To: jay.vosburgh@canonical.com
Cc: dbanerje@akamai.com, netdev@vger.kernel.org, vfalico@gmail.com,
andy@greyhouse.net
Subject: Re: [PATCH net-next v2 4/4] bonding: allow carrier and link status to determine link state
Date: Wed, 16 May 2018 12:28:47 -0400 (EDT) [thread overview]
Message-ID: <20180516.122847.2004339616613745427.davem@davemloft.net> (raw)
In-Reply-To: <26172.1526487068@nyx>
From: Jay Vosburgh <jay.vosburgh@canonical.com>
Date: Wed, 16 May 2018 18:11:08 +0200
> Debabrata Banerjee <dbanerje@akamai.com> wrote:
>
>>In a mixed environment it may be difficult to tell if your hardware
>>support carrier, if it does not it can always report true. With a new
>>use_carrier option of 2, we can check both carrier and link status
>>sequentially, instead of one or the other
>
> Your reply in the prior discussion suggests to me that there is
> a bug somewhere else (perhaps in bonding, perhaps in the network
> driver), and this is just papering over it. As I said, I don't believe
> that an additional hack to bonding is the appropriate way to resolve
> this.
Sorry this crossed with my review and application of this series, my bad.
Debabrata please give a specific example of a case where the new "both"
mode actually is needed.
Thank you.
next prev parent reply other threads:[~2018-05-16 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 18:48 [PATCH net-next v2 0/4] bonding: performance and reliability Debabrata Banerjee
2018-05-14 18:48 ` [PATCH net-next v2 1/4] bonding: don't queue up extraneous rlb updates Debabrata Banerjee
2018-05-14 18:48 ` [PATCH net-next v2 2/4] bonding: use common mac addr checks Debabrata Banerjee
2018-05-14 18:48 ` [PATCH net-next v2 3/4] bonding: allow use of tx hashing in balance-alb Debabrata Banerjee
2018-05-14 18:48 ` [PATCH net-next v2 4/4] bonding: allow carrier and link status to determine link state Debabrata Banerjee
2018-05-16 16:11 ` Jay Vosburgh
2018-05-16 16:28 ` David Miller [this message]
2018-05-16 16:54 ` Banerjee, Debabrata
2018-05-16 17:10 ` David Miller
2018-05-16 17:14 ` Banerjee, Debabrata
2018-05-16 17:20 ` David Miller
2018-05-16 16:16 ` [PATCH net-next v2 0/4] bonding: performance and reliability David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516.122847.2004339616613745427.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dbanerje@akamai.com \
--cc=jay.vosburgh@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).