From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 4/4] bonding: allow carrier and link status
 to determine link state
Date: Wed, 16 May 2018 12:28:47 -0400 (EDT)
Message-ID: <20180516.122847.2004339616613745427.davem@davemloft.net>
References: <20180514184810.15506-1-dbanerje@akamai.com>
        <20180514184810.15506-5-dbanerje@akamai.com>
        <26172.1526487068@nyx>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: dbanerje@akamai.com, netdev@vger.kernel.org, vfalico@gmail.com,
        andy@greyhouse.net
To: jay.vosburgh@canonical.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:42066 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751013AbeEPQ2t (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 16 May 2018 12:28:49 -0400
In-Reply-To: <26172.1526487068@nyx>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jay Vosburgh <jay.vosburgh@canonical.com>
Date: Wed, 16 May 2018 18:11:08 +0200

> Debabrata Banerjee <dbanerje@akamai.com> wrote:
> 
>>In a mixed environment it may be difficult to tell if your hardware
>>support carrier, if it does not it can always report true. With a new
>>use_carrier option of 2, we can check both carrier and link status
>>sequentially, instead of one or the other
> 
> 	Your reply in the prior discussion suggests to me that there is
> a bug somewhere else (perhaps in bonding, perhaps in the network
> driver), and this is just papering over it.  As I said, I don't believe
> that an additional hack to bonding is the appropriate way to resolve
> this.

Sorry this crossed with my review and application of this series, my bad.

Debabrata please give a specific example of a case where the new "both"
mode actually is needed.

Thank you.