From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v11 1/7] sched: Add Common Applications Kept
 Enhanced (cake) qdisc
Date: Wed, 16 May 2018 14:02:03 -0400 (EDT)
Message-ID: <20180516.140203.2185491961233997679.davem@davemloft.net>
References: <152639705919.2525.3718182212727523960.stgit@alrua-kau>
        <152639716493.2525.13568513738420279599.stgit@alrua-kau>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
To: toke@toke.dk
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:43170 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751698AbeEPSCG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 16 May 2018 14:02:06 -0400
In-Reply-To: <152639716493.2525.13568513738420279599.stgit@alrua-kau>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Tue, 15 May 2018 17:12:44 +0200

> +typedef u64 cobalt_time_t;
> +typedef s64 cobalt_tdiff_t;
 ...
> +static cobalt_time_t cobalt_get_time(void)
> +{
> +	return ktime_get_ns();
> +}
> +
> +static u32 cobalt_time_to_us(cobalt_time_t val)
> +{
> +	do_div(val, NSEC_PER_USEC);
> +	return (u32)val;
> +}

If fundamentally you are working with ktime_t values, please use that type
and the associated helpers.

This is a valid argument that using custom typedefs provide documentation
and an aid to understanding, but I think it doesn't serve that purpose
very well here.

So please just use ktime_t throughout instead of this cobalt_time_t
and cobalt_tdiff_t.  And then use helpers like ktime_to_us() which
properly optimize for 64-bit vs. 32-bit hosts.

Thank you.