netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: Allow more drivers with COMPILE_TEST
Date: Wed, 16 May 2018 14:17:38 -0400 (EDT)	[thread overview]
Message-ID: <20180516.141738.494765267490482500.davem@davemloft.net> (raw)
In-Reply-To: <20180516.141514.1102545495330180859.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 16 May 2018 14:15:14 -0400 (EDT)

> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 15 May 2018 16:48:22 -0700
> 
>> This patch series includes more drivers to be build tested with COMPILE_TEST
>> enabled. This helps cover some of the issues I just ran into with missing
>> a driver *sigh*.
> 
> Thank you for doing this.
> 
> Series applied.

Actually, I have to revert.

The FEC driver cannot be built tested without the appropriate platform
specific register set defines and x86-64 for example won't provide that.

drivers/net/ethernet/freescale/fec_main.c: In function ‘fec_restart’:
drivers/net/ethernet/freescale/fec_main.c:959:26: error: ‘FEC_RACC’ undeclared (first use in this function); did you mean ‘FEC_RXIC0’?
   val = readl(fep->hwp + FEC_RACC);
                          ^~~~~~~~
                          FEC_RXIC0
drivers/net/ethernet/freescale/fec_main.c:959:26: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/freescale/fec_main.c:968:38: error: ‘FEC_FTRL’ undeclared (first use in this function); did you mean ‘FEC_ECNTRL’?
   writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
                                      ^~~~~~~~
                                      FEC_ECNTRL
 ...

  reply	other threads:[~2018-05-16 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 23:48 [PATCH net-next 0/3] net: Allow more drivers with COMPILE_TEST Florian Fainelli
2018-05-15 23:48 ` [PATCH net-next 1/3] net: ethernet: ti: Allow most " Florian Fainelli
2018-05-17  3:02   ` kbuild test robot
2018-05-17  4:25   ` kbuild test robot
2018-05-15 23:48 ` [PATCH net-next 2/3] net: ethernet: freescale: Allow FEC " Florian Fainelli
2018-05-16  1:19   ` Andy Duan
2018-05-17  3:38   ` kbuild test robot
2018-05-17  4:03   ` kbuild test robot
2018-05-15 23:48 ` [PATCH net-next 3/3] net: phy: Allow MDIO_MOXART and MDIO_SUN4I " Florian Fainelli
2018-05-16 18:15 ` [PATCH net-next 0/3] net: Allow more drivers " David Miller
2018-05-16 18:17   ` David Miller [this message]
2018-05-16 18:18     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516.141738.494765267490482500.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).