From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE Date: Wed, 16 May 2018 14:37:14 -0400 (EDT) Message-ID: <20180516.143714.1321600980314123555.davem@davemloft.net> References: <1526442908-13183-1-git-send-email-roopa@cumulusnetworks.com> <1526442908-13183-2-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com, idosch@mellanox.com To: roopa@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:43794 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbeEPShQ (ORCPT ); Wed, 16 May 2018 14:37:16 -0400 In-Reply-To: <1526442908-13183-2-git-send-email-roopa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Roopa Prabhu Date: Tue, 15 May 2018 20:55:06 -0700 > +static int inet_rtm_getroute_reply(struct sk_buff *in_skb, struct nlmsghdr *nlh, > + __be32 dst, __be32 src, struct flowi4 *fl4, > + struct rtable *rt, struct fib_result *res) > +{ > + struct net *net = sock_net(in_skb->sk); > + struct rtmsg *rtm = nlmsg_data(nlh); > + u32 table_id = RT_TABLE_MAIN; > + struct sk_buff *skb; > + int err = 0; > + > + skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC); > + if (!skb) > + return -ENOMEM; If the caller can use GFP_KERNEL, so can this allocation.