From: David Miller <davem@davemloft.net>
To: Jose.Abreu@synopsys.com
Cc: netdev@vger.kernel.org, Joao.Pinto@synopsys.com,
Vitor.Soares@synopsys.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com
Subject: Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up
Date: Wed, 16 May 2018 14:56:11 -0400 (EDT) [thread overview]
Message-ID: <20180516.145611.65752290278287985.davem@davemloft.net> (raw)
In-Reply-To: <cover.1526474646.git.joabreu@synopsys.com>
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Wed, 16 May 2018 13:50:42 +0100
> David raised some rightfull constrains about the use of indirect callbacks in
> the code. I did iperf tests with and without patches 3-12 and the performance
> remained equal. I guess for 1Gb/s and because my setup has a powerfull
> processor these patches don't affect the performance.
Does your cpu need Spectre v1 and v2 workarounds which cause indirect calls to
be extremely expensive?
That's the case I'm worried about.
next prev parent reply other threads:[~2018-05-16 18:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 12:50 [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 01/12] net: stmmac: Enable OSP for GMAC4 Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 02/12] net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 03/12] net: stmmac: Let descriptor code set skbuff address Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 04/12] net: stmmac: Let descriptor code clear the descriptor Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 05/12] net: stmmac: Uniformize the use of dma_{rx/tx}_mode callbacks Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 06/12] net: stmmac: Remove uneeded checks for GMAC version Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 07/12] net: stmmac: Move PTP and MMC base address calculation to hwif.c Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 08/12] net: stmmac: Uniformize the use of dma_init_* callbacks Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 09/12] net: stmmac: Remove uneeded check for GMAC version in stmmac_xmit Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 10/12] net: stmmac: Uniformize set_rx_owner() Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 11/12] net: stmmac: Let descriptor code get skbuff address Jose Abreu
2018-05-16 12:50 ` [PATCH v2 net-next 12/12] net: stmmac: Remove if condition by taking advantage of hwif return code Jose Abreu
2018-05-16 18:56 ` David Miller [this message]
2018-05-16 19:01 ` [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up Florian Fainelli
2018-05-17 13:24 ` Jose Abreu
2018-05-17 18:41 ` David Miller
2018-05-17 18:47 ` David Miller
2018-05-18 9:17 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516.145611.65752290278287985.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Vitor.Soares@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).