From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Marcelo Ricardo Leitner <mleitner@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] tc-netem: fix limit description in man page
Date: Wed, 16 May 2018 14:28:25 -0700 [thread overview]
Message-ID: <20180516142825.1a11dcf2@xeon-e3> (raw)
In-Reply-To: <700b8303-28df-d991-6410-2f9d06f2b70d@gmail.com>
On Wed, 16 May 2018 15:17:50 -0600
David Ahern <dsahern@gmail.com> wrote:
> On 5/15/18 6:49 PM, Marcelo Ricardo Leitner wrote:
> > As the kernel code says, limit is actually the amount of packets it can
> > hold queued at a time, as per:
> >
> > static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch,
> > struct sk_buff **to_free)
> > {
> > ...
> > if (unlikely(sch->q.qlen >= sch->limit))
> > return qdisc_drop_all(skb, sch, to_free);
> >
> > So lets fix the description of the field in the man page.
> >
> > Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
> > ---
> > man/man8/tc-netem.8 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> applied to iproute2-next. Thanks,
>
Since it is an error, I will put it in master.
prev parent reply other threads:[~2018-05-16 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 0:49 [PATCH iproute2-next] tc-netem: fix limit description in man page Marcelo Ricardo Leitner
2018-05-16 21:17 ` David Ahern
2018-05-16 21:28 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516142825.1a11dcf2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).