From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2-next] tc-netem: fix limit description in man page Date: Wed, 16 May 2018 14:28:25 -0700 Message-ID: <20180516142825.1a11dcf2@xeon-e3> References: <700b8303-28df-d991-6410-2f9d06f2b70d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Marcelo Ricardo Leitner , netdev@vger.kernel.org To: David Ahern Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:33388 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbeEPV2a (ORCPT ); Wed, 16 May 2018 17:28:30 -0400 Received: by mail-pg0-f68.google.com with SMTP id v7-v6so857638pgs.0 for ; Wed, 16 May 2018 14:28:30 -0700 (PDT) In-Reply-To: <700b8303-28df-d991-6410-2f9d06f2b70d@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 16 May 2018 15:17:50 -0600 David Ahern wrote: > On 5/15/18 6:49 PM, Marcelo Ricardo Leitner wrote: > > As the kernel code says, limit is actually the amount of packets it can > > hold queued at a time, as per: > > > > static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, > > struct sk_buff **to_free) > > { > > ... > > if (unlikely(sch->q.qlen >= sch->limit)) > > return qdisc_drop_all(skb, sch, to_free); > > > > So lets fix the description of the field in the man page. > > > > Signed-off-by: Marcelo Ricardo Leitner > > --- > > man/man8/tc-netem.8 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > applied to iproute2-next. Thanks, > Since it is an error, I will put it in master.