From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH 00/14] Modify action API for implementing lockless actions Date: Wed, 16 May 2018 23:51:01 +0200 Message-ID: <20180516215101.GQ1972@nanopsycho> References: <23f37e5a-dd30-0ad3-a5ab-df22bf0ad7f9@mojatatu.com> <97ccb118-a3dc-6eb0-b127-9c04adf9e2fd@mojatatu.com> <2ee4066e-643a-f901-8926-7001f8699163@mojatatu.com> <85efib33kr.fsf@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roman Mashak , Jamal Hadi Salim , Linux Kernel Network Developers , David Miller , Cong Wang , pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, Daniel Borkmann , Eric Dumazet , kliteyn@mellanox.com To: Vlad Buslov Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:54549 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbeEPVvE (ORCPT ); Wed, 16 May 2018 17:51:04 -0400 Received: by mail-wm0-f65.google.com with SMTP id f6-v6so4929523wmc.4 for ; Wed, 16 May 2018 14:51:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Wed, May 16, 2018 at 11:23:41PM CEST, vladbu@mellanox.com wrote: > >On Wed 16 May 2018 at 17:36, Roman Mashak wrote: >> Vlad Buslov writes: >> >>> On Wed 16 May 2018 at 14:38, Roman Mashak wrote: >>>> On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: >>>>>>>>> I'm trying to run tdc, but keep getting following error even on clean >>>>>>>>> branch without my patches: >>>>>>>> >>>>>>>> Vlad, not sure if you saw my email: >>>>>>>> Apply Roman's patch and try again >>>>>>>> >>>>>>>> https://marc.info/?l=linux-netdev&m=152639369112020&w=2 >>>>>>>> >>>>>>>> cheers, >>>>>>>> jamal >>>>>>> >>>>>>> With patch applied I get following error: >>>>>>> >>>>>>> Test 7d50: Add skbmod action to set destination mac >>>>>>> exit: 255 0 >>>>>>> dst MAC address <11:22:33:44:55:66> >>>>>>> RTNETLINK answers: No such file or directory >>>>>>> We have an error talking to the kernel >>>>>>> >>>>>> >>>>>> You may actually have broken something with your patches in this case. >>>>> >>>>> Results is for net-next without my patches. >>>> >>>> Do you have skbmod compiled in kernel or as a module? >>> >>> Thanks, already figured out that default config has some actions >>> disabled. >>> Have more errors now. Everything related to ife: >>> >>> Test 7682: Create valid ife encode action with mark and pass control >>> exit: 255 0 >>> IFE type 0xED3E >>> RTNETLINK answers: No such file or directory >>> We have an error talking to the kernel >>> >>> Test ef47: Create valid ife encode action with mark and pipe control >>> exit: 255 0 >>> IFE type 0xED3E >>> RTNETLINK answers: No space left on device >>> We have an error talking to the kernel >>> >>> Test df43: Create valid ife encode action with mark and continue control >>> exit: 255 0 >>> IFE type 0xED3E >>> RTNETLINK answers: No space left on device >>> We have an error talking to the kernel >>> >>> Test e4cf: Create valid ife encode action with mark and drop control >>> exit: 255 0 >>> IFE type 0xED3E >>> RTNETLINK answers: No space left on device >>> We have an error talking to the kernel >>> >>> Test ccba: Create valid ife encode action with mark and reclassify control >>> exit: 255 0 >>> IFE type 0xED3E >>> RTNETLINK answers: No space left on device >>> We have an error talking to the kernel >>> >>> Test a1cf: Create valid ife encode action with mark and jump control >>> exit: 255 0 >>> IFE type 0xED3E >>> RTNETLINK answers: No space left on device >>> We have an error talking to the kernel >>> >>> ... >>> >>> >> >> Please make sure you have these in your kernel config: >> >> CONFIG_NET_ACT_IFE=y >> CONFIG_NET_IFE_SKBMARK=m >> CONFIG_NET_IFE_SKBPRIO=m >> CONFIG_NET_IFE_SKBTCINDEX=m Roman, could you please add this to some file? Something similar to: tools/testing/selftests/net/forwarding/config Thanks! >> >> For tdc to run all the tests, it is assumed that all the supported tc >> actions/filters are enabled and compiled. > >Enabling these options allowed all ife tests to pass. Thanks! > >Error in u32 test still appears however: > >Test e9a3: Add u32 with source match > >-----> prepare stage *** Could not execute: "$TC qdisc add dev $DEV1 ingress" > >-----> prepare stage *** Error message: "Cannot find device "v0p1"