From: David Miller <davem@davemloft.net>
To: amritha.nambiar@intel.com
Cc: netdev@vger.kernel.org, alexander.h.duyck@intel.com,
sridhar.samudrala@intel.com, edumazet@google.com,
hannes@stressinduktion.org, tom@herbertland.com
Subject: Re: [net-next PATCH v2 1/4] net: Refactor XPS for CPUs and Rx queues
Date: Thu, 17 May 2018 14:38:53 -0400 (EDT) [thread overview]
Message-ID: <20180517.143853.84077547534626009.davem@davemloft.net> (raw)
In-Reply-To: <152643400370.4991.2044471541271189575.stgit@anamdev.jf.intel.com>
From: Amritha Nambiar <amritha.nambiar@intel.com>
Date: Tue, 15 May 2018 18:26:43 -0700
> @@ -2125,7 +2125,7 @@ static bool remove_xps_queue_cpu(struct net_device *dev,
> int i, j;
>
> for (i = count, j = offset; i--; j++) {
> - if (!remove_xps_queue(dev_maps, cpu, j))
> + if (!remove_xps_queue(dev_maps, tci, j))
> break;
> }
>
This looks like a bug fix, completely unrelated to the feature being added
by this patch set.
Please submit this targetting the 'net' tree, then when that fix propagates
into 'net-next' you can rebase this series on top of that.
Thank you.
next prev parent reply other threads:[~2018-05-17 18:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 1:26 [net-next PATCH v2 0/4] Symmetric queue selection using XPS for Rx queues Amritha Nambiar
2018-05-16 1:26 ` [net-next PATCH v2 1/4] net: Refactor XPS for CPUs and " Amritha Nambiar
2018-05-17 18:38 ` David Miller [this message]
2018-05-17 18:47 ` Nambiar, Amritha
2018-05-18 4:08 ` Tom Herbert
2018-05-23 18:59 ` Nambiar, Amritha
2018-05-21 5:38 ` [lkp-robot] [net] 3416099d53: net/core/dev.c:#suspicious_rcu_dereference_protected()usage kernel test robot
2018-05-16 1:26 ` [net-next PATCH v2 2/4] net: Enable Tx queue selection based on Rx queues Amritha Nambiar
2018-05-18 4:03 ` Tom Herbert
2018-05-19 20:13 ` Willem de Bruijn
2018-05-19 20:27 ` Willem de Bruijn
2018-05-21 14:51 ` Tom Herbert
2018-05-21 15:12 ` Willem de Bruijn
2018-05-22 14:09 ` Tom Herbert
2018-05-23 19:31 ` Nambiar, Amritha
2018-05-23 19:19 ` Nambiar, Amritha
2018-05-16 1:26 ` [net-next PATCH v2 3/4] net-sysfs: Add interface for Rx queue map per Tx queue Amritha Nambiar
2018-05-17 19:05 ` Florian Fainelli
2018-05-17 22:43 ` Nambiar, Amritha
2018-05-16 1:27 ` [net-next PATCH v2 4/4] Documentation: Add explanation for XPS using Rx-queue map Amritha Nambiar
2018-05-18 4:11 ` [net-next PATCH v2 0/4] Symmetric queue selection using XPS for Rx queues Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517.143853.84077547534626009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).