From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH v2 net] net/ipv4: Initialize proto and ports in flow struct
Date: Thu, 17 May 2018 14:56:10 -0400 (EDT) [thread overview]
Message-ID: <20180517.145610.1726287379182269718.davem@davemloft.net> (raw)
In-Reply-To: <20180516203640.12568-1-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Wed, 16 May 2018 13:36:40 -0700
> Updating the FIB tracepoint for the recent change to allow rules using
> the protocol and ports exposed a few places where the entries in the flow
> struct are not initialized.
>
> For __fib_validate_source add the call to fib4_rules_early_flow_dissect
> since it is invoked for the input path. For netfilter, add the memset on
> the flow struct to avoid future problems like this. In ip_route_input_slow
> need to set the fields if the skb dissection does not happen.
>
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> Have not seen any problems with the IPv6 version
>
> v2
> - do not remove tracepoint in __fib_validate_source (sent the net-next
> version of this patch)
> - add set of ports and proto to ip_route_input_slow if skb dissect
> is not done
Applied, thanks David.
prev parent reply other threads:[~2018-05-17 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 20:36 [PATCH v2 net] net/ipv4: Initialize proto and ports in flow struct David Ahern
2018-05-16 20:53 ` Roopa Prabhu
2018-05-17 18:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517.145610.1726287379182269718.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).