From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 net] net/ipv4: Initialize proto and ports in flow
 struct
Date: Thu, 17 May 2018 14:56:10 -0400 (EDT)
Message-ID: <20180517.145610.1726287379182269718.davem@davemloft.net>
References: <20180516203640.12568-1-dsahern@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
To: dsahern@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:32924 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751438AbeEQS4M (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 14:56:12 -0400
In-Reply-To: <20180516203640.12568-1-dsahern@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Ahern <dsahern@gmail.com>
Date: Wed, 16 May 2018 13:36:40 -0700

> Updating the FIB tracepoint for the recent change to allow rules using
> the protocol and ports exposed a few places where the entries in the flow
> struct are not initialized.
> 
> For __fib_validate_source add the call to fib4_rules_early_flow_dissect
> since it is invoked for the input path. For netfilter, add the memset on
> the flow struct to avoid future problems like this. In ip_route_input_slow
> need to set the fields if the skb dissection does not happen.
> 
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> Have not seen any problems with the IPv6 version
> 
> v2
> - do not remove tracepoint in __fib_validate_source (sent the net-next
>   version of this patch)
> - add set of ports and proto to ip_route_input_slow if skb dissect
>   is not done

Applied, thanks David.