From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/8] tcp: default RACK loss recovery
Date: Thu, 17 May 2018 15:45:29 -0400 (EDT)
Message-ID: <20180517.154529.1714253947519146893.davem@davemloft.net>
References: <20180516234017.172775-1-ycheng@google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, edumazet@google.com, ncardwell@google.com,
        soheil@google.com, priyarjha@google.com
To: ycheng@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:33652 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750924AbeEQTpd (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 15:45:33 -0400
In-Reply-To: <20180516234017.172775-1-ycheng@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Yuchung Cheng <ycheng@google.com>
Date: Wed, 16 May 2018 16:40:09 -0700

> This patch set implements the features correspond to the
> draft-ietf-tcpm-rack-03 version of the RACK draft.
> https://datatracker.ietf.org/meeting/101/materials/slides-101-tcpm-update-on-tcp-rack-00
> 
> 1. SACK: implement equivalent DUPACK threshold heuristic in RACK to
>    replace existing RFC6675 recovery (tcp_mark_head_lost).
> 
> 2. Non-SACK: simplify RFC6582 NewReno implementation
> 
> 3. RTO: apply RACK's time-based approach to avoid spuriouly
>    marking very recently sent packets lost.
> 
> 4. with (1)(2)(3), make RACK the exclusive fast recovery mechanism to
>    mark losses based on time on S/ACK. Tail loss probe and F-RTO remain
>    enabled by default as complementary mechanisms to send probes in
>    CA_Open and CA_Loss states. The probes would solicit S/ACKs to trigger
>    RACK time-based loss detection.
> 
> All Google web and internal servers have been running RACK-only mode
> (4) for a while now. a/b experiments indicate RACK/TLP on average
> reduces recovery latency by 10% compared to RFC6675. RFC6675
> is default-off now but can be enabled by disabling RACK (sysctl
> net.ipv4.tcp_recovery=0) for unseen issues.

Series applied.

These patches, the design of the ordering of changes in the patch series,
and the commit messages themselves were more than a pleasure to read.

Really, this patch series is a great model for others who want to
improve the quality and reviewability of their submissions.

Thank you.