From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: qcom/emac: Allocate buffers from local node Date: Thu, 17 May 2018 15:57:02 -0400 (EDT) Message-ID: <20180517.155702.2252512582618641001.davem@davemloft.net> References: <1526545680-21650-1-git-send-email-hpuranik@codeaurora.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, timur@codeaurora.org To: hpuranik@codeaurora.org Return-path: In-Reply-To: <1526545680-21650-1-git-send-email-hpuranik@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Hemanth Puranik Date: Thu, 17 May 2018 13:58:00 +0530 > Currently we use non-NUMA aware allocation for TPD and RRD buffers, > this patch modifies to use NUMA friendly allocation. > > Signed-off-by: Hemanth Puranik > --- > drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.c b/drivers/net/ethernet/qualcomm/emac/emac-mac.c > index 092718a..c3df86a 100644 > --- a/drivers/net/ethernet/qualcomm/emac/emac-mac.c > +++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.c > @@ -684,9 +684,10 @@ static int emac_tx_q_desc_alloc(struct emac_adapter *adpt, > { > struct emac_ring_header *ring_header = &adpt->ring_header; > size_t size; > + int node = dev_to_node(adpt->netdev->dev.parent); Please order local variable declarations from longest to shortest line (ie. reverse christmas tree layout). > @@ -725,9 +726,10 @@ static int emac_rx_descs_alloc(struct emac_adapter *adpt) > struct emac_ring_header *ring_header = &adpt->ring_header; > struct emac_rx_queue *rx_q = &adpt->rx_q; > size_t size; > + int node = dev_to_node(adpt->netdev->dev.parent); Likewise.