From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>, Or Gerlitz <gerlitz.or@gmail.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Simon Horman <simon.horman@netronome.com>,
Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
John Hurley <john.hurley@netronome.com>,
Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>,
oss-drivers@netronome.com, Jan Gutter <jan.gutter@netronome.com>
Subject: Re: [patch net-next] nfp: flower: set sysfs link to device for representors
Date: Thu, 17 May 2018 10:51:23 -0700 [thread overview]
Message-ID: <20180517105123.7fea2de0@cakuba> (raw)
In-Reply-To: <20180517124210.GS1972@nanopsycho>
On Thu, 17 May 2018 14:42:10 +0200, Jiri Pirko wrote:
> Thu, May 17, 2018 at 02:25:14PM CEST, gerlitz.or@gmail.com wrote:
> >On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> >> From: Jiri Pirko <jiri@mellanox.com>
> >>
> >> Do this so the sysfs has "device" link correctly set.
> >
> >please no
> >
> >This is likely to create bunch of issues with respect to how libvirt
> >deals with the representors.
>
> Once netdev is there because of some probed pci device, this link should
> be set. That is one of the basics.
>
> What "bunch of issues" are you talking about? Please be specific.
Libvirt may pick any device under sys/bus/pci/devices/$vf/physfn/net/
to run legacy SR-IOV NDOs on. nfp currently exposes those on all
representors.
Or correctly points out that running SR-IOV NDOs on non-PF reprs makes
very limited amount of sense and we should fix libvirt and remove the
NDOs for non-PF nfp reprs.
AFAICT since nfp does provide the NDOs on all reprs nothing should
break with this patch, but ip link will now start listing VF state on
each representor. Meaning that if we have 100 VFs enabled simple "ip
link list" will produce upwards of 10,000 lines of output.
next prev parent reply other threads:[~2018-05-17 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 10:05 [patch net-next] nfp: flower: set sysfs link to device for representors Jiri Pirko
2018-05-17 12:25 ` Or Gerlitz
2018-05-17 12:42 ` Jiri Pirko
2018-05-17 17:51 ` Jakub Kicinski [this message]
2018-05-21 15:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517105123.7fea2de0@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=gerlitz.or@gmail.com \
--cc=jan.gutter@netronome.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).