From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [patch net-next] nfp: flower: set sysfs link to device for
 representors
Date: Thu, 17 May 2018 10:51:23 -0700
Message-ID: <20180517105123.7fea2de0@cakuba>
References: <20180517100520.23971-1-jiri@resnulli.us>
        <CAJ3xEMgw0Ar4_Zvm4cirjf7XgaPf8Ufos+vEjRmMq5OM2yg_aw@mail.gmail.com>
        <20180517124210.GS1972@nanopsycho>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Linux Netdev List <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Simon Horman <simon.horman@netronome.com>,
        Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
        John Hurley <john.hurley@netronome.com>,
        Pieter Jansen van Vuuren
        <pieter.jansenvanvuuren@netronome.com>, oss-drivers@netronome.com,
        Jan Gutter <jan.gutter@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>, Or Gerlitz <gerlitz.or@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f67.google.com ([209.85.160.67]:37850 "EHLO
        mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751047AbeEQRv1 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 13:51:27 -0400
Received: by mail-pl0-f67.google.com with SMTP id w19-v6so2977353plq.4
        for <netdev@vger.kernel.org>; Thu, 17 May 2018 10:51:26 -0700 (PDT)
In-Reply-To: <20180517124210.GS1972@nanopsycho>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 17 May 2018 14:42:10 +0200, Jiri Pirko wrote:
> Thu, May 17, 2018 at 02:25:14PM CEST, gerlitz.or@gmail.com wrote:
> >On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko <jiri@resnulli.us> wrote:  
> >> From: Jiri Pirko <jiri@mellanox.com>
> >>
> >> Do this so the sysfs has "device" link correctly set.  
> >
> >please no
> >
> >This is likely to create bunch of issues with respect to how libvirt
> >deals with the representors.  
> 
> Once netdev is there because of some probed pci device, this link should
> be set. That is one of the basics.
> 
> What "bunch of issues" are you talking about? Please be specific.

Libvirt may pick any device under sys/bus/pci/devices/$vf/physfn/net/
to run legacy SR-IOV NDOs on.  nfp currently exposes those on all
representors.  

Or correctly points out that running SR-IOV NDOs on non-PF reprs makes
very limited amount of sense and we should fix libvirt and remove the
NDOs for non-PF nfp reprs.

AFAICT since nfp does provide the NDOs on all reprs nothing should
break with this patch, but ip link will now start listing VF state on
each representor.  Meaning that if we have 100 VFs enabled simple "ip
link list" will produce upwards of 10,000 lines of output.