From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next] nfp: flower: fix error path during representor creation Date: Thu, 17 May 2018 10:56:37 -0700 Message-ID: <20180517105637.0328a0ab@cakuba> References: <20180517100643.24044-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, simon.horman@netronome.com, dirk.vandermerwe@netronome.com, john.hurley@netronome.com, pieter.jansenvanvuuren@netronome.com, oss-drivers@netronome.com To: Jiri Pirko Return-path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:36267 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbeEQR4l (ORCPT ); Thu, 17 May 2018 13:56:41 -0400 Received: by mail-pg0-f46.google.com with SMTP id z70-v6so2160249pgz.3 for ; Thu, 17 May 2018 10:56:41 -0700 (PDT) In-Reply-To: <20180517100643.24044-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 17 May 2018 12:06:43 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Don't store repr pointer to reprs array until the representor is > successfully created. This avoids message about "representor > destruction" even when it was never created. Also it cleans-up the flow. > Also, check return value after port alloc. > > Signed-off-by: Jiri Pirko Reviewed-by: Jakub Kicinski Thank you!