From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [patch net-next] nfp: flower: set sysfs link to device for
 representors
Date: Thu, 17 May 2018 14:42:10 +0200
Message-ID: <20180517124210.GS1972@nanopsycho>
References: <20180517100520.23971-1-jiri@resnulli.us>
 <CAJ3xEMgw0Ar4_Zvm4cirjf7XgaPf8Ufos+vEjRmMq5OM2yg_aw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linux Netdev List <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Simon Horman <simon.horman@netronome.com>,
        Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
        John Hurley <john.hurley@netronome.com>,
        Pieter Jansen van Vuuren
        <pieter.jansenvanvuuren@netronome.com>, oss-drivers@netronome.com
To: Or Gerlitz <gerlitz.or@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34799 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751843AbeEQMmM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 08:42:12 -0400
Received: by mail-wm0-f67.google.com with SMTP id a137-v6so5297378wme.1
        for <netdev@vger.kernel.org>; Thu, 17 May 2018 05:42:11 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAJ3xEMgw0Ar4_Zvm4cirjf7XgaPf8Ufos+vEjRmMq5OM2yg_aw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thu, May 17, 2018 at 02:25:14PM CEST, gerlitz.or@gmail.com wrote:
>On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Do this so the sysfs has "device" link correctly set.
>
>please no
>
>This is likely to create bunch of issues with respect to how libvirt
>deals with the representors.

Once netdev is there because of some probed pci device, this link should
be set. That is one of the basics.

What "bunch of issues" are you talking about? Please be specific.


>
>We were discussing it off list between nfp and mlnx driver people. We
>need to put
>the open stack folks and kernel developers into the same thread. I can
>make a post
>on that next week