From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when
 creating a new link
Date: Thu, 17 May 2018 15:36:04 -0700
Message-ID: <20180517153604.0d905a36@xeon-e3>
References: <20180517222237.72388-1-dsahern@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
To: dsahern@kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f67.google.com ([209.85.160.67]:36178 "EHLO
        mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751543AbeEQWgH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 18:36:07 -0400
Received: by mail-pl0-f67.google.com with SMTP id v24-v6so3379009plo.3
        for <netdev@vger.kernel.org>; Thu, 17 May 2018 15:36:07 -0700 (PDT)
In-Reply-To: <20180517222237.72388-1-dsahern@kernel.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 17 May 2018 16:22:37 -0600
dsahern@kernel.org wrote:

> From: David Ahern <dsahern@gmail.com>
> 
> Using iproute2 to create a bridge and add 4094 vlans to it can take from
> 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index.
> ll_name_to_index results in an ioctl(SIOCGIFINDEX) call which in turn
> invokes dev_load. If the index does not exist, which it won't when
> creating a new link, dev_load calls modprobe twice -- once for
> netdev-NAME and again for NAME. This is unnecessary overhead for each
> link create.
> 
> When ip link is invoked for a new device, there is no reason to
> call ll_name_to_index for the new device. With this patch, creating
> a bridge and adding 4094 vlans takes less than 3 *seconds*.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Yes this looks like a real problem.
Isn't the cache supposed to reduce this?

Don't like to make lots of special case flags.