From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports Date: Thu, 17 May 2018 22:48:55 +0200 Message-ID: <20180517204855.GX1972@nanopsycho> References: <20180322105522.8186-5-jiri@resnulli.us> <20180323133002.GF5145@lunn.ch> <20180323144914.GA2125@nanopsycho> <20180517140239.GT1972@nanopsycho> <189f0c4d-aacb-73b9-0ff6-9feefe320c46@gmail.com> <20180517143020.GU1972@nanopsycho> <4ba82a94-18c9-e5bb-8e96-11af8cfefa73@gmail.com> <20180517173907.GW1972@nanopsycho> <408e70ee-d3b4-8431-5ca7-6defa17b7088@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Lunn , netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com, jakub.kicinski@netronome.com, mlxsw@mellanox.com, vivien.didelot@savoirfairelinux.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com, satananda.burla@cavium.com, raghu.vatsavayi@cavium.com, felix.manlunas@cavium.com, gospo@broadcom.com, sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com, tariqt@mellanox.com, eranbe@mellanox.com, jeffrey.t.kirsher@intel.com To: Florian Fainelli Return-path: Received: from mail-wr0-f174.google.com ([209.85.128.174]:40546 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbeEQUs6 (ORCPT ); Thu, 17 May 2018 16:48:58 -0400 Received: by mail-wr0-f174.google.com with SMTP id v60-v6so6997391wrc.7 for ; Thu, 17 May 2018 13:48:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <408e70ee-d3b4-8431-5ca7-6defa17b7088@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, May 17, 2018 at 09:14:32PM CEST, f.fainelli@gmail.com wrote: >On 05/17/2018 10:39 AM, Jiri Pirko wrote: >>>> That is compiled inside "fixed_phy", isn't it? >>> >>> It matches what CONFIG_FIXED_PHY is, so if it's built-in it also becomes >>> built-in, if is modular, it is also modular, this was fixed with >>> 40013ff20b1beed31184935fc0aea6a859d4d4ef ("net: dsa: Fix functional >>> dsa-loop dependency on FIXED_PHY") >> >> Now I have it compiled as module, and after modprobe dsa_loop I see: >> [ 1168.129202] libphy: Fixed MDIO Bus: probed >> [ 1168.222716] dsa-loop fixed-0:1f: DSA mockup driver: 0x1f >> >> This messages I did not see when I had fixed_phy compiled as buildin. >> >> But I still see no netdevs :/ > >The platform data assumes there is a network device named "eth0" as the Oups, I missed, I created dummy device and modprobed again. Now I see: $ sudo devlink port mdio_bus/fixed-0:1f/0: type eth netdev lan1 mdio_bus/fixed-0:1f/1: type eth netdev lan2 mdio_bus/fixed-0:1f/2: type eth netdev lan3 mdio_bus/fixed-0:1f/3: type eth netdev lan4 mdio_bus/fixed-0:1f/4: type notset mdio_bus/fixed-0:1f/5: type notset mdio_bus/fixed-0:1f/6: type notset mdio_bus/fixed-0:1f/7: type notset mdio_bus/fixed-0:1f/8: type notset mdio_bus/fixed-0:1f/9: type notset mdio_bus/fixed-0:1f/10: type notset mdio_bus/fixed-0:1f/11: type notset I wonder why there are ports 4-11 >parent device, yes I know this is terrible, but unfortunately we don't >have anything better at this point, though that could certainly change >that to take a proper struct device reference in the future. > >I am assuming that you don't have such a network device named "eth0" in >your system? You can also look at the less than 360 LOCs of the driver >and find out where your problem is, this is not mlxsw :) Yeah, I'm a bit lost in the embedded/dsa world :)