* [net PATCH] net: Fix a bug in removing queues from XPS map
@ 2018-05-17 21:50 Amritha Nambiar
2018-05-18 16:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Amritha Nambiar @ 2018-05-17 21:50 UTC (permalink / raw)
To: netdev, davem
Cc: alexander.h.duyck, f.fainelli, amritha.nambiar, sridhar.samudrala,
edumazet, hannes, tom
While removing queues from the XPS map, the individual CPU ID
alone was used to index the CPUs map, this should be changed to also
factor in the traffic class mapping for the CPU-to-queue lookup.
Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes")
Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 9f43901..9397577 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2125,7 +2125,7 @@ static bool remove_xps_queue_cpu(struct net_device *dev,
int i, j;
for (i = count, j = offset; i--; j++) {
- if (!remove_xps_queue(dev_maps, cpu, j))
+ if (!remove_xps_queue(dev_maps, tci, j))
break;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net PATCH] net: Fix a bug in removing queues from XPS map
2018-05-17 21:50 [net PATCH] net: Fix a bug in removing queues from XPS map Amritha Nambiar
@ 2018-05-18 16:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-05-18 16:07 UTC (permalink / raw)
To: amritha.nambiar
Cc: netdev, alexander.h.duyck, f.fainelli, sridhar.samudrala,
edumazet, hannes, tom
From: Amritha Nambiar <amritha.nambiar@intel.com>
Date: Thu, 17 May 2018 14:50:44 -0700
> While removing queues from the XPS map, the individual CPU ID
> alone was used to index the CPUs map, this should be changed to also
> factor in the traffic class mapping for the CPU-to-queue lookup.
>
> Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes")
> Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
> Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Applied and queued up for -stable, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-18 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-17 21:50 [net PATCH] net: Fix a bug in removing queues from XPS map Amritha Nambiar
2018-05-18 16:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).