From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next 0/5] devlink: introduce port flavours and common phys_port_name generation Date: Fri, 18 May 2018 14:16:49 -0700 Message-ID: <20180518141649.30f90d59@cakuba> References: <20180518072904.29523-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com, satananda.burla@cavium.com, raghu.vatsavayi@cavium.com, felix.manlunas@cavium.com, gospo@broadcom.com, sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com, tariqt@mellanox.com, eranbe@mellanox.com, jeffrey.t.kirsher@intel.com, roopa@cumulusnetworks.com To: Jiri Pirko Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:37245 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbeERVQz (ORCPT ); Fri, 18 May 2018 17:16:55 -0400 Received: by mail-qt0-f195.google.com with SMTP id q13-v6so12111748qtp.4 for ; Fri, 18 May 2018 14:16:55 -0700 (PDT) In-Reply-To: <20180518072904.29523-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 18 May 2018 09:28:59 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf > represenatation but the user has no way to see which is which > 2) The ndo_get_phys_port_name is implemented in each driver separatelly, > which may lead to inconsistent names between drivers. > > This patchset introduces port flavours which should address the first > problem. In this initial patchset, I focus on DSA and their port > flavours. As a follow-up, I plan to add PF and VF representor flavours. > However, that needs additional dependencies in drivers (nfp, mlx5). > > The common phys_port_name generation is used by mlxsw. An example output > for mlxsw looks like this: FWIW this series LGTM!