From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: [net-next 2/2] ena: Fix settings/advertising for ethtool Date: Fri, 18 May 2018 09:59:47 -0700 Message-ID: <20180518165947.20948-3-jeffrey.t.kirsher@intel.com> References: <20180518165947.20948-1-jeffrey.t.kirsher@intel.com> Cc: Jeff Kirsher , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com, Mitch Williams To: davem@davemloft.net, netanel@amazon.com, saeedb@amazon.com, zorik@amazon.com Return-path: Received: from mga02.intel.com ([134.134.136.20]:46147 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbeERQ60 (ORCPT ); Fri, 18 May 2018 12:58:26 -0400 In-Reply-To: <20180518165947.20948-1-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: It appears that the Amazon Ethernet driver was setting bits in the 'settings' field twice. Almost certainly this was supposed to set bits in the 'advertising' field instead. CC: Mitch Williams Signed-off-by: Jeff Kirsher Tested-by: Aaron Brown --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c index 0a4de911e6cc..2f5e4cf84934 100644 --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c @@ -283,7 +283,7 @@ static int ena_get_link_ksettings(struct net_device *netdev, if (link->flags & ENA_ADMIN_GET_FEATURE_LINK_DESC_AUTONEG_MASK) { ethtool_ks_add_mode(link_ksettings, supported, Autoneg); - ethtool_ks_add_mode(link_ksettings, supported, Autoneg); + ethtool_ks_add_mode(link_ksettings, advertising, Autoneg); } link_ksettings->base.autoneg = -- 2.17.0