From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [net-next 0/2][pull request] 40GbE Intel Wired LAN Driver Updates 2018-05-18
Date: Sat, 19 May 2018 23:04:49 -0400 (EDT) [thread overview]
Message-ID: <20180519.230449.682040894703931700.davem@davemloft.net> (raw)
In-Reply-To: <20180518165947.20948-1-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 18 May 2018 09:59:45 -0700
> Mitch shortens the ethtool link settings API function names to help
> reduce the amount of line wrapping done in the drivers, and also to make
> the ethtool link settings API functions less windows like (i.e. function
> names that are full sentences). Since we do not have all the hardware
> available from all the other vendors, we did only compile testing for
> most of the non-Intel drivers.
This is so much churn, which is going to cause -stable backport pains.
The time to bike shed interface names is not after hundreds of drivers
have been converted to use them, but rather beforehand.
Sorry, I'm very much not inclined to apply this.
Thanks.
prev parent reply other threads:[~2018-05-20 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 16:59 [net-next 0/2][pull request] 40GbE Intel Wired LAN Driver Updates 2018-05-18 Jeff Kirsher
2018-05-18 16:59 ` [net-next 1/2] ethtool: stop the line wrapping madness Jeff Kirsher
2018-05-18 16:59 ` [net-next 2/2] ena: Fix settings/advertising for ethtool Jeff Kirsher
2018-05-20 3:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519.230449.682040894703931700.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).