From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCHv2 net-next] erspan: set bso bit based on mirrored packet's len Date: Sun, 20 May 2018 18:32:35 -0400 (EDT) Message-ID: <20180520.183235.1631404265072288763.davem@davemloft.net> References: <1526697661-8958-1-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tobin@apporbit.com To: u9012063@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:46720 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbeETWcg (ORCPT ); Sun, 20 May 2018 18:32:36 -0400 In-Reply-To: <1526697661-8958-1-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: William Tu Date: Fri, 18 May 2018 19:41:01 -0700 > Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not > handled. BSO has 4 possible values: > 00 --> Good frame with no error, or unknown integrity > 11 --> Payload is a Bad Frame with CRC or Alignment Error > 01 --> Payload is a Short Frame > 10 --> Payload is an Oversized Frame > > Based the short/oversized definitions in RFC1757, the patch sets > the bso bit based on the mirrored packet's size. > > Reported-by: Xiaoyan Jin > Signed-off-by: William Tu > --- > v1->v2 > Improve code comments, make enum erspan_bso clearer Applied, thanks William.