[PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

[PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

[Florian Fainelli]

Provide a means for !OF platforms to supply their DSA platform data
configuration using the dsa_platform_data structure.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 include/linux/platform_data/b53.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/platform_data/b53.h b/include/linux/platform_data/b53.h
index 69d279c0da96..8eaef2f2b691 100644
--- a/include/linux/platform_data/b53.h
+++ b/include/linux/platform_data/b53.h
@@ -20,8 +20,12 @@
 #define __B53_H
 
 #include <linux/kernel.h>
+#include <net/dsa.h>
 
 struct b53_platform_data {
+	/* Must be first such that dsa_register_switch() can access it */
+	struct dsa_chip_data cd;
+
 	u32 chip_id;
 	u16 enabled_ports;
 
-- 
2.14.1

Re: [PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

[Andrew Lunn]

On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
> Provide a means for !OF platforms to supply their DSA platform data
> configuration using the dsa_platform_data structure.

Hi Florian

It seems a bit odd adding the header file, but no code. Yes, this will
help simplify the merge dependencies for the ZII boards next cycle,
but can we have the actual code as well?

    Thanks
	Andrew
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  include/linux/platform_data/b53.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/platform_data/b53.h b/include/linux/platform_data/b53.h
> index 69d279c0da96..8eaef2f2b691 100644
> --- a/include/linux/platform_data/b53.h
> +++ b/include/linux/platform_data/b53.h
> @@ -20,8 +20,12 @@
>  #define __B53_H
>  
>  #include <linux/kernel.h>
> +#include <net/dsa.h>
>  
>  struct b53_platform_data {
> +	/* Must be first such that dsa_register_switch() can access it */
> +	struct dsa_chip_data cd;
> +
>  	u32 chip_id;
>  	u16 enabled_ports;
>  
> -- 
> 2.14.1
> 

Re: [PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

[Florian Fainelli]

On May 19, 2018 6:42:50 PM PDT, Andrew Lunn <andrew@lunn.ch> wrote:
>On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
>> Provide a means for !OF platforms to supply their DSA platform data
>> configuration using the dsa_platform_data structure.
>
>Hi Florian
>
>It seems a bit odd adding the header file, but no code. Yes, this will
>help simplify the merge dependencies for the ZII boards next cycle,
>but can we have the actual code as well?

The existing b53_common.c file already makes use of platform data the only thing that was missing was a dsa_chip_data structure correctly placed for the core DSA layer to obtain port information. This was present from day one in the b53 driver because it is also the mechanism used by the bus specific drivers to pass information to the core b53 driver file.
Hi Andrew,
-- 
Florian

Re: [PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

[Andrew Lunn]

On Sat, May 19, 2018 at 08:14:41PM -0700, Florian Fainelli wrote:
> On May 19, 2018 6:42:50 PM PDT, Andrew Lunn <andrew@lunn.ch> wrote:
> >On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
> >> Provide a means for !OF platforms to supply their DSA platform data
> >> configuration using the dsa_platform_data structure.
> >
> >Hi Florian
> >
> >It seems a bit odd adding the header file, but no code. Yes, this will
> >help simplify the merge dependencies for the ZII boards next cycle,
> >but can we have the actual code as well?
> 
> The existing b53_common.c file already makes use of platform data the only thing that was missing was a dsa_chip_data structure correctly placed for the core DSA layer to obtain port information. This was present from day one in the b53 driver because it is also the mechanism used by the bus specific drivers to pass information to the core b53 driver file.

Ah. It would of been good to say that in the commit message.

    Andrew

Re: [PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

[Florian Fainelli]

On 05/20/2018 07:06 AM, Andrew Lunn wrote:
> On Sat, May 19, 2018 at 08:14:41PM -0700, Florian Fainelli wrote:
>> On May 19, 2018 6:42:50 PM PDT, Andrew Lunn <andrew@lunn.ch> wrote:
>>> On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
>>>> Provide a means for !OF platforms to supply their DSA platform data
>>>> configuration using the dsa_platform_data structure.
>>>
>>> Hi Florian
>>>
>>> It seems a bit odd adding the header file, but no code. Yes, this will
>>> help simplify the merge dependencies for the ZII boards next cycle,
>>> but can we have the actual code as well?
>>
>> The existing b53_common.c file already makes use of platform data the only thing that was missing was a dsa_chip_data structure correctly placed for the core DSA layer to obtain port information. This was present from day one in the b53 driver because it is also the mechanism used by the bus specific drivers to pass information to the core b53 driver file.
> 
> Ah. It would of been good to say that in the commit message.

Make sense, v2 coming. Thanks!
-- 
Florian