Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ganeshgr@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
	indranil@chelsio.com, venkatesh@chelsio.com, leedom@chelsio.com
Subject: Re: [PATCH net-next] cxgb4: do L1 config when module is inserted
Date: Mon, 21 May 2018 12:23:30 -0400 (EDT)	[thread overview]
Message-ID: <20180521.122330.1373279676577548.davem@davemloft.net> (raw)
In-Reply-To: <20180521.122104.1660333635075713378.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Mon, 21 May 2018 12:21:04 -0400 (EDT)

> From: Ganesh Goudar <ganeshgr@chelsio.com>
> Date: Mon, 21 May 2018 14:45:43 +0530
> 
>> trigger an L1 configure operation when a transceiver module
>> is inserted in order to cause current "sticky" options like
>> Requested Forward Error Correction to be reapplied.
>> 
>> Signed-off-by: Casey Leedom <leedom@chelsio.com>
>> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
> 
> Applied, although:

Actually I had to revert, this doesn't even compile:

drivers/scsi/csiostor/csio_hw.c: In function ‘fwcaps16_to_caps32’:
drivers/scsi/csiostor/csio_hw.c:1490:17: error: ‘FW_PORT_CAP_MDIX’ undeclared (first use in this function); did you mean ‘FW_PORT_CAP_MDI_S’?
    if (caps16 & FW_PORT_CAP_##__cap) \
                 ^

  reply	other threads:[~2018-05-21 16:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21  9:15 [PATCH net-next] cxgb4: do L1 config when module is inserted Ganesh Goudar
2018-05-21 16:21 ` David Miller
2018-05-21 16:23   ` David Miller [this message]
2018-05-23  1:47 ` kbuild test robot
2018-05-23  3:29 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521.122330.1373279676577548.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ganeshgr@chelsio.com \
    --cc=indranil@chelsio.com \
    --cc=leedom@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    --cc=venkatesh@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox