From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next] net: phy: phylink: Don't release NULL GPIO Date: Mon, 21 May 2018 14:00:54 +0200 Message-ID: <20180521120054.GB27140@lunn.ch> References: <20180521034947.469-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, rmk+kernel@armlinux.org.uk, "David S. Miller" , open list To: Florian Fainelli Return-path: Content-Disposition: inline In-Reply-To: <20180521034947.469-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, May 20, 2018 at 08:49:47PM -0700, Florian Fainelli wrote: > If CONFIG_GPIOLIB is disabled, gpiod_put() becomes a stub that produces a > warning, this helped identify that we could be attempting to release a NULL > pl->link_gpio GPIO descriptor, so guard against that. > > Fixes: daab3349ad1a ("net: phy: phylink: Release link GPIO") > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew