From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net 2/4] virtio-net: correctly transmit XDP buff after linearizing Date: Mon, 21 May 2018 18:03:51 +0300 Message-ID: <20180521180346-mutt-send-email-mst@kernel.org> References: <1526891706-18516-1-git-send-email-jasowang@redhat.com> <1526891706-18516-3-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, John Fastabend To: Jason Wang Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52860 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751021AbeEUPDw (ORCPT ); Mon, 21 May 2018 11:03:52 -0400 Content-Disposition: inline In-Reply-To: <1526891706-18516-3-git-send-email-jasowang@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, May 21, 2018 at 04:35:04PM +0800, Jason Wang wrote: > We should not go for the error path after successfully transmitting a > XDP buffer after linearizing. Since the error path may try to pop and > drop next packet and increase the drop counters. Fixing this by simply > drop the refcnt of original page and go for xmit path. > > Fixes: 72979a6c3590 ("virtio_net: xdp, add slowpath case for non contiguous buffers") > Cc: John Fastabend > Signed-off-by: Jason Wang Acked-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index c15d240..6260d65 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -775,7 +775,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, > } > *xdp_xmit = true; > if (unlikely(xdp_page != page)) > - goto err_xdp; > + put_page(page); > rcu_read_unlock(); > goto xdp_xmit; > case XDP_REDIRECT: > -- > 2.7.4