From mboxrd@z Thu Jan 1 00:00:00 1970 From: hiren panchasara Subject: Re: [PATCH net-next 0/8] tcp: default RACK loss recovery Date: Mon, 21 May 2018 11:39:09 -0700 Message-ID: <20180521183909.GB71807@strugglingcoder.info> References: <20180516234017.172775-1-ycheng@google.com> <20180517.154529.1714253947519146893.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Cc: ycheng@google.com, netdev@vger.kernel.org, edumazet@google.com, ncardwell@google.com, soheil@google.com, priyarjha@google.com To: David Miller Return-path: Received: from strugglingcoder.info ([104.236.146.68]:57402 "EHLO mail.strugglingcoder.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbeEUSpN (ORCPT ); Mon, 21 May 2018 14:45:13 -0400 Content-Disposition: inline In-Reply-To: <20180517.154529.1714253947519146893.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/17/18 at 03:45P, David Miller wrote: > From: Yuchung Cheng > Date: Wed, 16 May 2018 16:40:09 -0700 >=20 > > This patch set implements the features correspond to the > > draft-ietf-tcpm-rack-03 version of the RACK draft. > > https://datatracker.ietf.org/meeting/101/materials/slides-101-tcpm-upda= te-on-tcp-rack-00 > >=20 > > 1. SACK: implement equivalent DUPACK threshold heuristic in RACK to > > replace existing RFC6675 recovery (tcp_mark_head_lost). > >=20 > > 2. Non-SACK: simplify RFC6582 NewReno implementation > >=20 > > 3. RTO: apply RACK's time-based approach to avoid spuriouly > > marking very recently sent packets lost. > >=20 > > 4. with (1)(2)(3), make RACK the exclusive fast recovery mechanism to > > mark losses based on time on S/ACK. Tail loss probe and F-RTO remain > > enabled by default as complementary mechanisms to send probes in > > CA_Open and CA_Loss states. The probes would solicit S/ACKs to trigg= er > > RACK time-based loss detection. > >=20 > > All Google web and internal servers have been running RACK-only mode > > (4) for a while now. a/b experiments indicate RACK/TLP on average > > reduces recovery latency by 10% compared to RFC6675. RFC6675 > > is default-off now but can be enabled by disabling RACK (sysctl > > net.ipv4.tcp_recovery=3D0) for unseen issues. >=20 > Series applied. >=20 > These patches, the design of the ordering of changes in the patch series, > and the commit messages themselves were more than a pleasure to read. >=20 > Really, this patch series is a great model for others who want to > improve the quality and reviewability of their submissions. Second that as a maintainer of a non-linux stack. Thanks a ton for such clear and crisp commit-log messages along with the actual changes. Cheers, Hiren --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJbAxJGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lPacH/1sF+tRIq9Afp4sz9pGX5JAD sfjMHEXwNYuOezA6O4sbY7G69XVJE/a2Cc7T3UNH6bk/yvCLf4VL5Ek0DNAN8gRT QLrcV65NbXl+Q58ENSJscb95jZijuFTvkNvyaFaR4GTqYAvnIqBjuxnvcsKDqZ7S T25NMKM70ZL7qV9vdeQlNdFafmXcgFrxd2IyuAsILZjrk5xZ1K5f8NtpgA8wnGyU i0reGh5mK80v/DPX4wSIC2MZMcYkRw0GRuXM43q9+7Q6xUTc2pWhiz+yXOdWS6KG QovfN5+XxKGh6tU7YU3kPfg5YY42hRi/wTEWd3a+zQQpnJJQn2TVfpoVlfCz71I= =RzKm -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--