From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Tue, 22 May 2018 11:08:53 +0200 Message-ID: <20180522090853.GF2149@nanopsycho> References: <1526954781-35359-1-git-send-email-sridhar.samudrala@intel.com> <1526954781-35359-3-git-send-email-sridhar.samudrala@intel.com> <20180522090637.GE2149@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mst@redhat.com, stephen@networkplumber.org, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, aaron.f.brown@intel.com, anjali.singhai@intel.com To: Sridhar Samudrala Return-path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:44607 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeEVJJC (ORCPT ); Tue, 22 May 2018 05:09:02 -0400 Received: by mail-wr0-f172.google.com with SMTP id y15-v6so18735226wrg.11 for ; Tue, 22 May 2018 02:09:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180522090637.GE2149@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: Tue, May 22, 2018 at 11:06:37AM CEST, jiri@resnulli.us wrote: >Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala@intel.com wrote: >>Use the registration/notification framework supported by the generic >>failover infrastructure. >> >>Signed-off-by: Sridhar Samudrala > >In previous patchset versions, the common code did >netdev_rx_handler_register() and netdev_upper_dev_link() etc >(netvsc_vf_join()). Now, this is still done in netvsc. Why? > >This should be part of the common "failover" code. > Also note that in the current patchset you use IFF_FAILOVER flag for master, yet for the slave you use IFF_SLAVE. That is wrong. IFF_FAILOVER_SLAVE should be used.