From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: Shepherd request (P83): Multipath TCP: Present Use Cases and an Upstream Future Date: Tue, 22 May 2018 18:46:21 +0300 Message-ID: <20180522184112-mutt-send-email-mst@kernel.org> References: <1526954781-35359-1-git-send-email-sridhar.samudrala@intel.com> <1526954781-35359-3-git-send-email-sridhar.samudrala@intel.com> <20180522090637.GE2149@nanopsycho> <20180522090853.GF2149@nanopsycho> <39081bce-3913-5b07-3d07-0c476fca5e78@intel.com> <20180522153614.GK2149@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: "Samudrala, Sridhar" , stephen@networkplumber.org, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, aaron.f.brown@intel.com, anjali.singhai@intel.com To: Jiri Pirko Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <20180522153614.GK2149@nanopsycho> List-Id: netdev.vger.kernel.org On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudrala@intel.com wrote: > > > >On 5/22/2018 2:08 AM, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 11:06:37AM CEST, jiri@resnulli.us wrote: > >> > Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala@intel.com wrote: > >> > > Use the registration/notification framework supported by the generic > >> > > failover infrastructure. > >> > > > >> > > Signed-off-by: Sridhar Samudrala > >> > In previous patchset versions, the common code did > >> > netdev_rx_handler_register() and netdev_upper_dev_link() etc > >> > (netvsc_vf_join()). Now, this is still done in netvsc. Why? > >> > > >> > This should be part of the common "failover" code. > > > >Based on Stephen's feedback on earlier patches, i tried to minimize the changes to > >netvsc and only commonize the notifier and the main event handler routine. > >Another complication is that netvsc does part of registration in a delayed workqueue. > > :( This kind of degrades the whole efford of having single solution > in "failover" module. I think that common parts, as > netdev_rx_handler_register() and others certainly is should be inside > the common module. This is not a good time to minimize changes. Let's do > the thing properly and fix the netvsc mess now. > > > > > >It should be possible to move some of the code from net_failover.c to generic > >failover.c in future if Stephen is ok with it. > > > > > >> > > >> Also note that in the current patchset you use IFF_FAILOVER flag for > >> master, yet for the slave you use IFF_SLAVE. That is wrong. > >> IFF_FAILOVER_SLAVE should be used. > > > >Not sure which code you are referring to.  I only set IFF_FAILOVER_SLAVE > >in patch 3. > > The existing netvsc driver. We really can't change netvsc's flags now, even if it's interface is messy, it's being used in the field. We can add a flag that makes netvsc behave differently, and if this flag also allows enhanced functionality userspace will gradually switch. Anything breaking userspace I fully expect Stephen to nack and IMO with good reason. -- MST