From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Tue, 22 May 2018 22:54:35 +0300 Message-ID: <20180522204216-mutt-send-email-mst@kernel.org> References: <20180522161007-mutt-send-email-mst@kernel.org> <20180522131422.GG2149@nanopsycho> <20180522161509-mutt-send-email-mst@kernel.org> <20180522132626.GH2149@nanopsycho> <20180522163502-mutt-send-email-mst@kernel.org> <20180522151343.GJ2149@nanopsycho> <20180522181804-mutt-send-email-mst@kernel.org> <20180522154501.GL2149@nanopsycho> <20180522194633-mutt-send-email-mst@kernel.org> <20180522173844.GP2149@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sridhar Samudrala , stephen@networkplumber.org, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, aaron.f.brown@intel.com, anjali.singhai@intel.com To: Jiri Pirko Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <20180522173844.GP2149@nanopsycho> List-Id: netdev.vger.kernel.org On Tue, May 22, 2018 at 07:38:44PM +0200, Jiri Pirko wrote: > >> >> In private > >> >> flag. I don't see no reason to break this pattern here. > >> > > >> >Other masters are setup from userspace, this one is set up automatically > >> >by kernel. So the bar is higher, we need an interface that existing > >> >userspace knows about. We can't just say "oh if userspace set this up > >> >it should know to skip lowerdevs". > >> > > >> >Otherwise multiple interfaces with same mac tend to confuse userspace. > >> > >> No difference, really. > >> Regardless who does the setup, and independent userspace deamon should > >> react accordingly. > > > >If the deamon does the setup itself, it's reasonable to require that it > >learns about new flags each time we add a new driver. If it doesn't, > >then I think it's less reasonable. > > No need. The "IFLA_MASTER" attr is always there to be looked at. That is > enough. Oh so if it has an master, skip it? Sorry, I misunderstood what you were saying earlier. Thanks, this makes sense to me. -- MST