From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ibmvnic: Only do H_EOI for mobility events Date: Wed, 23 May 2018 14:54:44 -0400 (EDT) Message-ID: <20180523.145444.1321544791132829125.davem@davemloft.net> References: <152700607013.58815.10070919641026174502.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com, tlfalcon@linux.vnet.ibm.com To: nfont@linux.vnet.ibm.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33398 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933928AbeEWSyp (ORCPT ); Wed, 23 May 2018 14:54:45 -0400 In-Reply-To: <152700607013.58815.10070919641026174502.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nathan Fontenot Date: Tue, 22 May 2018 11:21:10 -0500 > When enabling the sub-CRQ IRQ a previous update sent a H_EOI prior > to the enablement to clear any pending interrupts that may be present > across a partition migration. This fixed a firmware bug where a > migration could erroneously indicate that a H_EOI was pending. > > The H_EOI should only be sent when enabling during a mobility > event though. Doing so at other time could wrong and can produce > extra driver output when IRQs are enabled when doing TX completion. > > Signed-off-by: Nathan Fontenot Applied, thanks.