From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute Date: Wed, 23 May 2018 13:19:44 -0700 Message-ID: <20180523131944.3498fd10@cakuba> References: <20180521210502.11082-1-saeedm@mellanox.com> <20180521210502.11082-2-saeedm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netdev@vger.kernel.org, Huy Nguyen To: Saeed Mahameed Return-path: Received: from mail-qk0-f181.google.com ([209.85.220.181]:39968 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934241AbeEWUTt (ORCPT ); Wed, 23 May 2018 16:19:49 -0400 Received: by mail-qk0-f181.google.com with SMTP id r66-v6so2161605qkr.7 for ; Wed, 23 May 2018 13:19:49 -0700 (PDT) In-Reply-To: <20180521210502.11082-2-saeedm@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h > index 2c0c6453c3f4..1ddc0a44c172 100644 > --- a/include/uapi/linux/dcbnl.h > +++ b/include/uapi/linux/dcbnl.h > @@ -163,6 +163,15 @@ struct ieee_pfc { > __u64 indications[IEEE_8021QAZ_MAX_TCS]; > }; > > +#define IEEE_8021Q_MAX_PRIORITIES 8 > +#define DCBX_MAX_BUFFERS 8 > +struct dcbnl_buffer { > + /* priority to buffer mapping */ > + __u8 prio2buffer[IEEE_8021Q_MAX_PRIORITIES]; > + /* buffer size in Bytes */ > + __u32 buffer_size[DCBX_MAX_BUFFERS]; Could you use IEEE_8021Q_MAX_PRIORITIES to size this array? The DCBX in the define name sort of implies this is coming from the standard which it isn't. > +}; > + > /* CEE DCBX std supported values */ > #define CEE_DCBX_MAX_PGS 8 > #define CEE_DCBX_MAX_PRIO 8