From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute Date: Wed, 23 May 2018 13:28:26 -0700 Message-ID: <20180523132826.397d41a9@cakuba> References: <20180521210502.11082-1-saeedm@mellanox.com> <20180521210502.11082-2-saeedm@mellanox.com> <20180521222026.4f54f479@cakuba> <20180523094331.GC3046@nanopsycho> <653806e9-8416-d1e9-8666-abeea8eb7f15@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Huy Nguyen , Jiri Pirko , Saeed Mahameed , "David S. Miller" , netdev@vger.kernel.org, Or Gerlitz To: John Fastabend Return-path: Received: from mail-qt0-f177.google.com ([209.85.216.177]:32817 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934245AbeEWU2b (ORCPT ); Wed, 23 May 2018 16:28:31 -0400 Received: by mail-qt0-f177.google.com with SMTP id e8-v6so29881855qth.0 for ; Wed, 23 May 2018 13:28:31 -0700 (PDT) In-Reply-To: <653806e9-8416-d1e9-8666-abeea8eb7f15@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 23 May 2018 09:03:53 -0700, John Fastabend wrote: > On 05/23/2018 08:37 AM, Huy Nguyen wrote: > > > > > > On 5/23/2018 8:52 AM, John Fastabend wrote: > >> It would be nice though if the API gave us some hint on max/min/stride > >> of allowed values. Could the get API return these along with current > >> value? Presumably the allowed max size could change with devlink buffer > >> changes in how the global buffer is divided up as well. > > Acked. I will add Max. Let's skip min/stride since it is too hardware specific. > > At minimum then we need to document for driver writers what to do > with a value that falls between strides. Round-up or round-down. BTW I feel like stride would be a good addition to devlink-sb, too!