netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: jiri@mellanox.com, jakub.kicinski@netronome.com,
	paulb@mellanox.com, netdev@vger.kernel.org,
	ASAP_Direct_Dev@mellanox.com
Subject: Re: [PATCH net] net : sched: cls_api: deal with egdev path only if needed
Date: Thu, 24 May 2018 22:13:47 -0400 (EDT)	[thread overview]
Message-ID: <20180524.221347.1439890185309496728.davem@davemloft.net> (raw)
In-Reply-To: <1527092688-27496-1-git-send-email-ogerlitz@mellanox.com>

From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Wed, 23 May 2018 19:24:48 +0300

> When dealing with ingress rule on a netdev, if we did fine through the
> conventional path, there's no need to continue into the egdev route,
> and we can stop right there.
> 
> Not doing so may cause a 2nd rule to be added by the cls api layer
> with the ingress being the egdev.
> 
> For example, under sriov switchdev scheme, a user rule of VFR A --> VFR B
> will end up with two HW rules (1) VF A --> VF B and (2) uplink --> VF B
> 
> Fixes: 208c0f4b5237 ('net: sched: use tc_setup_cb_call to call per-block callbacks')
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>

Applied and queued up for -stable.

> As I wrote in [1], we are asking this patch to go into net and 
> stable >= 4.15 but not carried into net-next.

Please send me a revert with a detailed commit message when this
gets merged into net-next.

Thanks.

      reply	other threads:[~2018-05-25  2:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 16:24 [PATCH net] net : sched: cls_api: deal with egdev path only if needed Or Gerlitz
2018-05-25  2:13 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524.221347.1439890185309496728.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ASAP_Direct_Dev@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=paulb@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).