From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] hv_netvsc: fix bogus ifalias on network device Date: Thu, 24 May 2018 23:10:18 -0400 (EDT) Message-ID: <20180524.231018.981173045711989778.davem@davemloft.net> References: <20180524010200.11722-1-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sthemmin@microsoft.com To: stephen@networkplumber.org Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54784 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbeEYDKT (ORCPT ); Thu, 24 May 2018 23:10:19 -0400 In-Reply-To: <20180524010200.11722-1-sthemmin@microsoft.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Stephen Hemminger Date: Wed, 23 May 2018 18:02:00 -0700 > If the guest network adapter is not configured with DeviceNaming > enabled on the host, then the query for friendly name will return > success but with a zero length name. Which then leads to a garbage value > (stack contents) for ifalias. > > Fix is simple, just don't set name if host doesn't return it. > > Fixes: 0fe554a46a0f ("hv_netvsc: propogate Hyper-V friendly name into interface alias") > Signed-off-by: Stephen Hemminger Applied.