* [PATCH net-next] bpfilter: fix build dependency
@ 2018-05-24 4:29 Alexei Starovoitov
2018-05-24 10:33 ` Daniel Borkmann
2018-05-24 13:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2018-05-24 4:29 UTC (permalink / raw)
To: David S . Miller; +Cc: daniel, jakub.kicinski, netdev, kernel-team
BPFILTER could have been enabled without INET causing this build error:
ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined!
Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
---
net/bpfilter/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
index 60725c5f79db..a948b072c28f 100644
--- a/net/bpfilter/Kconfig
+++ b/net/bpfilter/Kconfig
@@ -1,7 +1,7 @@
menuconfig BPFILTER
bool "BPF based packet filtering framework (BPFILTER)"
default n
- depends on NET && BPF
+ depends on NET && BPF && INET
help
This builds experimental bpfilter framework that is aiming to
provide netfilter compatible functionality via BPF
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bpfilter: fix build dependency
2018-05-24 4:29 [PATCH net-next] bpfilter: fix build dependency Alexei Starovoitov
@ 2018-05-24 10:33 ` Daniel Borkmann
2018-05-24 13:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2018-05-24 10:33 UTC (permalink / raw)
To: Alexei Starovoitov, David S . Miller; +Cc: jakub.kicinski, netdev, kernel-team
On 05/24/2018 06:29 AM, Alexei Starovoitov wrote:
> BPFILTER could have been enabled without INET causing this build error:
> ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined!
>
> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
> Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bpfilter: fix build dependency
2018-05-24 4:29 [PATCH net-next] bpfilter: fix build dependency Alexei Starovoitov
2018-05-24 10:33 ` Daniel Borkmann
@ 2018-05-24 13:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-24 13:33 UTC (permalink / raw)
To: ast; +Cc: daniel, jakub.kicinski, netdev, kernel-team
From: Alexei Starovoitov <ast@kernel.org>
Date: Wed, 23 May 2018 21:29:05 -0700
> BPFILTER could have been enabled without INET causing this build error:
> ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined!
>
> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
> Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-24 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-24 4:29 [PATCH net-next] bpfilter: fix build dependency Alexei Starovoitov
2018-05-24 10:33 ` Daniel Borkmann
2018-05-24 13:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).