From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net-next] vrf: add CRC32c offload to device features Date: Thu, 24 May 2018 16:54:51 -0300 Message-ID: <20180524195451.GL26212@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: David Ahern , Vlad Yasevich , linux-sctp@vger.kernel.org, netdev@vger.kernel.org To: Davide Caratti Return-path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:35829 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967986AbeEXTy4 (ORCPT ); Thu, 24 May 2018 15:54:56 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, May 24, 2018 at 05:49:35PM +0200, Davide Caratti wrote: > SCTP sockets originated in a VRF can improve their performance if CRC32c > computation is delegated to underlying devices: update device features, > setting NETIF_F_SCTP_CRC. Iterating the following command in the topology > proposed with [1], > > # ip vrf exec vrf-h2 netperf -H 192.0.2.1 -t SCTP_STREAM -- -m 10K > > the measured throughput in Mbit/s improved from 2395 ± 1% to 2720 ± 1%. > > [1] https://www.spinics.net/lists/netdev/msg486007.html > > Signed-off-by: Davide Caratti Reviewed-by: Marcelo Ricardo Leitner > --- > drivers/net/vrf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > index 90b5f3900c22..f93547f257fb 100644 > --- a/drivers/net/vrf.c > +++ b/drivers/net/vrf.c > @@ -1254,7 +1254,7 @@ static void vrf_setup(struct net_device *dev) > > /* enable offload features */ > dev->features |= NETIF_F_GSO_SOFTWARE; > - dev->features |= NETIF_F_RXCSUM | NETIF_F_HW_CSUM; > + dev->features |= NETIF_F_RXCSUM | NETIF_F_HW_CSUM | NETIF_F_SCTP_CRC; > dev->features |= NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA; > > dev->hw_features = dev->features; > -- > 2.17.0 >