From: Jon Maxwell <jmaxwell37@gmail.com>
To: davem@davemloft.net
Cc: dsahern@gmail.com, mschiffer@universe-factory.net,
zhangshengju@cmss.chinamobile.com, ktkhai@virtuozzo.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jmaxwell@redhat.com
Subject: [PATCH net-next] ifb: fix packets checksum
Date: Fri, 25 May 2018 07:38:29 +1000 [thread overview]
Message-ID: <20180524213829.15208-1-jmaxwell37@gmail.com> (raw)
Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path.
Otherwise we get splats when tc mirred is used to redirect packets to ifb.
Before fix:
nic: hw csum failure
Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
---
drivers/net/ifb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index 5f2897ec0edc..d345c61d476c 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -102,7 +102,7 @@ static void ifb_ri_tasklet(unsigned long _txp)
if (!skb->tc_from_ingress) {
dev_queue_xmit(skb);
} else {
- skb_pull(skb, skb->mac_len);
+ skb_pull_rcsum(skb, skb->mac_len);
netif_receive_skb(skb);
}
}
--
2.13.6
next reply other threads:[~2018-05-24 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 21:38 Jon Maxwell [this message]
2018-05-25 20:43 ` [PATCH net-next] ifb: fix packets checksum David Miller
2018-05-28 23:13 ` Jonathan Maxwell
2018-05-29 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524213829.15208-1-jmaxwell37@gmail.com \
--to=jmaxwell37@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jmaxwell@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).