From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default Date: Fri, 25 May 2018 14:39:50 -0400 (EDT) Message-ID: <20180525.143950.1016974537238779353.davem@davemloft.net> References: <6fd70d33-11f7-33dd-3b11-e5031fe46466@cogentembedded.com> <2273548.5hmqMeOsCk@bentobox> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sven@narfation.org, sw@simonwunderlich.de, netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, joe@perches.com To: sergei.shtylyov@cogentembedded.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:35844 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967453AbeEYSjy (ORCPT ); Fri, 25 May 2018 14:39:54 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Sergei Shtylyov Date: Fri, 25 May 2018 18:56:09 +0300 > On 05/25/2018 02:15 PM, Sven Eckelmann wrote: > >>>> [...] >>>>>> --- a/net/batman-adv/Kconfig >>>>>> +++ b/net/batman-adv/Kconfig >>>>>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS >>>>>> bool "batman-adv debugfs entries" >>>>>> depends on BATMAN_ADV >>>>>> depends on DEBUG_FS >>>>>> - default y >>>>>> + default n >>>>> >>>>> N is the default default. :-) You don't need this line. >>>> >>>> Hm, looks like this would have to be changed in a lot of places (~782 >>>> according to `git grep 'default n$'|wc -l` in my slightly outdated linux- >>>> next). Do you want to fix it everywhere? >>> >>> No, but we can at least not add the new ones... >> >> But the patch was added to net-next yesterday. > > DaveM is still too fast for me. :-) No worries, just let's get a patch to remove the line.