From: Stephen Hemminger <stephen@networkplumber.org>
To: Sridhar Samudrala <sridhar.samudrala@intel.com>
Cc: mst@redhat.com, davem@davemloft.net, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com,
anjali.singhai@intel.com
Subject: Re: [PATCH net-next v12 1/5] net: Introduce generic failover module
Date: Fri, 25 May 2018 15:37:44 -0700 [thread overview]
Message-ID: <20180525153744.2b53c449@xeon-e3> (raw)
In-Reply-To: <1527180917-39737-2-git-send-email-sridhar.samudrala@intel.com>
On Thu, 24 May 2018 09:55:13 -0700
Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
> + spin_lock(&failover_lock);
Since register is not in fast path, this should be a mutex?
> +int failover_slave_unregister(struct net_device *slave_dev)
> +{
> + struct net_device *failover_dev;
> + struct failover_ops *fops;
> +
> + if (!netif_is_failover_slave(slave_dev))
> + goto done;
> +
> + ASSERT_RTNL();
> +
> + failover_dev = failover_get_bymac(slave_dev->perm_addr, &fops);
> + if (!failover_dev)
> + goto done;
Since the slave device must have a master device set already, why not use
that instead of searching by MAC address on unregister or link change.
next prev parent reply other threads:[~2018-05-25 22:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 16:55 [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 1/5] net: Introduce generic failover module Sridhar Samudrala
2018-05-25 22:37 ` Stephen Hemminger [this message]
2018-05-25 23:04 ` Samudrala, Sridhar
2018-05-26 7:43 ` Jiri Pirko
2018-05-25 22:38 ` Stephen Hemminger
2018-05-25 23:06 ` Samudrala, Sridhar
2018-05-25 23:29 ` Stephen Hemminger
2018-05-31 2:52 ` Stephen Hemminger
2018-05-31 2:58 ` Samudrala, Sridhar
2018-05-24 16:55 ` [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-05-25 22:34 ` Stephen Hemminger
2018-05-25 23:11 ` Samudrala, Sridhar
2018-05-25 23:28 ` Stephen Hemminger
2018-05-26 7:22 ` Samudrala, Sridhar
2018-05-26 7:51 ` Jiri Pirko
2018-05-26 19:22 ` Samudrala, Sridhar
2018-05-31 2:06 ` Stephen Hemminger
2018-05-31 3:03 ` Samudrala, Sridhar
2018-05-31 12:58 ` Stephen Hemminger
2018-05-31 17:34 ` Michael S. Tsirkin
2018-05-31 18:35 ` Michael S. Tsirkin
2018-05-31 20:41 ` Siwei Liu
2018-05-24 16:55 ` [PATCH net-next v12 3/5] net: Introduce net_failover driver Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 4/5] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 5/5] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-05-25 17:19 ` [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device Michael S. Tsirkin
2018-05-29 3:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525153744.2b53c449@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=aaron.f.brown@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=loseweigh@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox