From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits Date: Fri, 25 May 2018 18:23:07 +0200 Message-ID: <20180525162307.GB28900@lst.de> References: <20180525143512.1466-1-hch@lst.de> <20180525143512.1466-2-hch@lst.de> <20180525145012.GA3863@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fenghua Yu , Tony Luck , linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ingo Molnar , Thomas Gleixner , Christoph Hellwig To: Greg Kroah-Hartman Return-path: Content-Disposition: inline In-Reply-To: <20180525145012.GA3863-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote: > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote: > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits > > even if the device itself supports more. Add a single bit flag to > > struct device (to be moved into the dma extension once we around it) > > "once we around it"? I don't understand, sorry. Should be "once we get around it", which in proper grammar should probably be "once we get to it". Anyway, the point is that right now struct device is bloated with a lot of fields for dma/iommu purposes and we need to clean this up. It's been on my TODO list for a while.