From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: missing headers
 test_lwt_seg6local
Date: Fri, 25 May 2018 09:23:14 -0700
Message-ID: <20180525162312.dadn2wtcp4bkf2la@ast-mbp>
References: <20180525112036.4768-1-m.xhonneux@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, ys114321@gmail.com, daniel@iogearbox.net
To: Mathieu Xhonneux <m.xhonneux@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:41625 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966854AbeEYQXR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 25 May 2018 12:23:17 -0400
Received: by mail-pl0-f65.google.com with SMTP id az12-v6so3432328plb.8
        for <netdev@vger.kernel.org>; Fri, 25 May 2018 09:23:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180525112036.4768-1-m.xhonneux@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, May 25, 2018 at 12:20:36PM +0100, Mathieu Xhonneux wrote:
> Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks
> some UAPI headers in tools/.
> 
> clang -I. -I./include/uapi -I../../../include/uapi -idirafter
> /usr/local/include -idirafter
> /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include
> -idirafter /usr/include -Wno-compare-distinct-pointer-types \
>          -O2 -target bpf -emit-llvm -c test_lwt_seg6local.c -o - |      \
> llc -march=bpf -mcpu=generic  -filetype=obj -o
> [...]/net-next/tools/testing/selftests/bpf/test_lwt_seg6local.o
> test_lwt_seg6local.c:4:10: fatal error: 'linux/seg6_local.h' file not found
>          ^~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> make: Leaving directory
> `/data/users/yhs/work/net-next/tools/testing/selftests/bpf'
> 
> Reported-by: Y Song <ys114321@gmail.com>
> Signed-off-by: Mathieu Xhonneux <m.xhonneux@gmail.com>
> ---
>  .../selftests/bpf/include/uapi/linux/seg6.h        | 55 +++++++++++++++
>  .../selftests/bpf/include/uapi/linux/seg6_local.h  | 80 ++++++++++++++++++++++
>  2 files changed, 135 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/include/uapi/linux/seg6.h
>  create mode 100644 tools/testing/selftests/bpf/include/uapi/linux/seg6_local.h
> 
> diff --git a/tools/testing/selftests/bpf/include/uapi/linux/seg6.h b/tools/testing/selftests/bpf/include/uapi/linux/seg6.h

hmm. why to selftest?
Shouldn't they be added to tools/include/uapi/linux/ instead?