From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event
 handling code to use the failover framework
Date: Fri, 25 May 2018 16:28:39 -0700
Message-ID: <20180525162839.3c7028e1@xeon-e3>
References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com>
        <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com>
        <20180525153456.28b44c7c@xeon-e3>
        <c0be8e44-34f8-0e46-3a51-7ce869a5d351@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: mst@redhat.com, davem@davemloft.net, netdev@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
        alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
        loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com,
        anjali.singhai@intel.com
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f66.google.com ([74.125.83.66]:46659 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1030651AbeEYX2m (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 25 May 2018 19:28:42 -0400
Received: by mail-pg0-f66.google.com with SMTP id a3-v6so2879162pgt.13
        for <netdev@vger.kernel.org>; Fri, 25 May 2018 16:28:42 -0700 (PDT)
In-Reply-To: <c0be8e44-34f8-0e46-3a51-7ce869a5d351@intel.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 25 May 2018 16:11:47 -0700
"Samudrala, Sridhar" <sridhar.samudrala@intel.com> wrote:

> On 5/25/2018 3:34 PM, Stephen Hemminger wrote:
> > On Thu, 24 May 2018 09:55:14 -0700
> > Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
> >  
> >> --- a/drivers/net/hyperv/Kconfig
> >> +++ b/drivers/net/hyperv/Kconfig
> >> @@ -2,5 +2,6 @@ config HYPERV_NET
> >>   	tristate "Microsoft Hyper-V virtual network driver"
> >>   	depends on HYPERV
> >>   	select UCS2_STRING
> >> +	select FAILOVER  
> > When I take a working kernel config, add the patches then do
> > make oldconfig
> >
> > It is not autoselecting FAILOVER, it prompts me for it. This means
> > if user says no then a non-working netvsc device is made.  
> 
> I see
>     Generic failover module (FAILOVER) [M/y/?] (NEW)
> 
> So the user is given an option to either build as a Module or part of the
> kernel. 'n' is not an option.

With most libraries there is no prompt at all.