From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: [PATCH, net-next] qcom-emag: hide ACPI specific functions Date: Fri, 25 May 2018 23:37:10 +0200 Message-ID: <20180525213714.2120604-1-arnd@arndb.de> Cc: Arnd Bergmann , Hemanth Puranik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Timur Tabi , "David S. Miller" Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org A couple of functions in this file are only used when building with ACPI enabled, leading to a build warning on most architectures: drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:284:25: error: 'qdf2400_ops' defined but not used [-Werror=unused-variable] static struct sgmii_ops qdf2400_ops = { ^~~~~~~~~~~ drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:276:25: error: 'qdf2432_ops' defined but not used [-Werror=unused-variable] static struct sgmii_ops qdf2432_ops = { This hides all the unused functions by putting them into the corresponding #ifdef. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c index 562420b834df..01b80e0a5367 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c +++ b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c @@ -108,6 +108,7 @@ static void emac_sgmii_link_init(struct emac_adapter *adpt) writel(val, phy->base + EMAC_SGMII_PHY_AUTONEG_CFG2); } +#ifdef CONFIG_ACPI static int emac_sgmii_irq_clear(struct emac_adapter *adpt, u8 irq_bits) { struct emac_sgmii *phy = &adpt->phy; @@ -288,6 +289,7 @@ static struct sgmii_ops qdf2400_ops = { .link_change = emac_sgmii_common_link_change, .reset = emac_sgmii_common_reset, }; +#endif static int emac_sgmii_acpi_match(struct device *dev, void *data) { -- 2.9.0